Skip to content

feat: add webapi response changes as of 2026-05-13#1588

Merged
zimeg merged 3 commits into
mainfrom
api
May 18, 2026
Merged

feat: add webapi response changes as of 2026-05-13#1588
zimeg merged 3 commits into
mainfrom
api

Conversation

@slackapi
Copy link
Copy Markdown
Contributor

@slackapi slackapi Bot commented May 13, 2026 •
edited by zimeg
Loading

This PR updates the web API client and model based on the production E2E test results.

Category

  • slack-api-model (Slack API Data Models)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@slackapi slackapi Bot requested a review from a team as a code owner May 13, 2026 09:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (02ec6cd) to head (a4684f8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1588      +/-   ##
============================================
- Coverage     73.29%   73.28%   -0.01%     
+ Complexity     4519     4518       -1     
============================================
  Files           478      478              
  Lines         14298    14298              
  Branches       1490     1490              
============================================
- Hits          10480    10479       -1     
- Misses         2930     2931       +1     
  Partials        888      888
Flag Coverage Δ
jdk-14 73.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Copy Markdown
Member

zimeg commented May 13, 2026

👾 Eek! A few polish needed but an alright start @slackapi[bot]!

@zimeg zimeg marked this pull request as draft May 13, 2026 09:19
@zimeg
Copy link
Copy Markdown
Member

zimeg commented May 13, 2026

🗣️ Am wanting to revisit this soon with request and response arguments too but I will sleep on an approach toward this-

@zimeg
feat: add is_modified_by_ai and slack_file_id properties
00301d1 
Add missing properties detected during remote API tests:
- is_modified_by_ai to File and MatchedItem models
- slack_file_id to Attachment model

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added project:slack-api-model project:slack-api-model semver:patch labels May 13, 2026
@zimeg zimeg self-assigned this May 13, 2026
@zimeg zimeg modified the milestone: 1.48.2 May 13, 2026
zimeg
zimeg reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Words after inspecting these changes-

Comment thread slack-api-model/src/main/java/com/slack/api/model/File.java
private boolean canvasPrintingEnabled;

private boolean isAiSuggested;
private boolean isModifiedByAi;
Copy link
Copy Markdown
Member

@zimeg zimeg May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾 note: True!

zimeg
zimeg approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉 With generous self approval too!

@zimeg zimeg marked this pull request as ready for review May 13, 2026 20:55
@zimeg
Copy link
Copy Markdown
Member

zimeg commented May 18, 2026

🗣️ Will merge this to avoid adding more recent changes to this commit.

@zimeg zimeg enabled auto-merge (squash) May 18, 2026 17:01
@zimeg zimeg merged commit fc11ab4 into main May 18, 2026
7 checks passed
@zimeg zimeg deleted the api branch May 18, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@zimeg zimeg

Labels

project:slack-api-model project:slack-api-model semver:patch

Projects

None yet

Milestone

1.48.2

Development

Successfully merging this pull request may close these issues.

1 participant

@zimeg